On 17-Jan-13 20:18, Mike Stump wrote:
You are now entered into the most ignored and most trivial gcc patch contest. You presently are behind the leader, but, if you can get another 10 pings in before approval, you can win! Good luck.
Thanks. I know it's trivial, but 1. it's not hard to ping, and 2. for some reason small bugs just nag me :)
On 17-Jan-13 21:15, Maxim Kuvyrkov wrote:
Thanks for hanging out for so long. A couple of tips to increase your
> luck with getting a patch reviewed. First, address your submission to > specific people, use your best-guess to choose a maintainer who can > review this patch. Otherwise diffusion of responsibility will kill > your patch (everyone will think that someone else will review it).
Thanks, I'll keep that in mind. >
Second -- present the full problem statement in the patch submission,
> don't just reference a PR . To make a click we (reviewers and > maintainers) need to move our hand from keyboard to mouse, and that's > so hard when we are just scanning the mailing list.
OK. It just seemed redundant to put the same information in both the bug tracker and the mailing list. Again, I'll remember to provide more info.
Lastly, your patch is OK with the following nitpicks. I will check in
> your [updated] patch once GCC 4.8 branches and trunk opens for > development. [Strictly, I'm not a maintainer, but this is a trivial > cleanup.]
<snip />+ +#endif /* __ RTP __ */ /* This is a global structure which records all of the active keys. @@ -150,7 +158,7 @@ static __gthread_once_t tls_init_guard = need to read tls_keys.dtor[key] atomically. */ static void -tls_delete_hook (void *tcb ATTRIBUTE_UNUSED) +tls_delete_hook (void *tcb)Don't remove ATTRIBUTE_UNUSED. TCB was and will remain unused #ifdef __RTP__.
And #ifndef __RTP__ ? Thanks for looking! I'll make the necessary changes. -- Robert
