On 14/02/2013, at 10:18 AM, rbmj wrote: > On 18-Jan-13 20:35, Maxim Kuvyrkov wrote: >> On 19/01/2013, at 9:18 AM, rbmj wrote: >> >>>>> -150,7 +158,7 @@ static __gthread_once_t tls_init_guard = >>>>> need to read tls_keys.dtor[key] atomically. */ >>>>> >>>>> static void >>>>> -tls_delete_hook (void *tcb ATTRIBUTE_UNUSED) >>>>> +tls_delete_hook (void *tcb) >>>> >>>> Don't remove ATTRIBUTE_UNUSED. TCB was and will remain unused #ifdef >>>> __RTP__. >>>> >>> >>> And #ifndef __RTP__ ? >> >> No, simply leave that line as is. ATTRIBUTE_UNUSED tells the compiler that >> a variable can be unused, but not necessarily is unused. It's fine to have >> this attribute set on variables that are used under certain preprocessor >> configurations. >> > > Seems like I kept this email in drafts and never sent it out... > > Sorry about that. > > Here's the updated, (trivial) patch.
Thanks. I'll apply this once 4.8 branches and trunk is back into development mode. -- Maxim Kuvyrkov