On Sun, Jun 8, 2014 at 6:44 PM, Jan Hubicka <hubi...@ucw.cz> wrote: >> Honza, >> >> I finally was able to bootstrap GCC on AIX yesterday. The bootstrap >> works, but the testsuite results are in extremely bad shape: 250 >> failures in G++ testsuite and 470 failures in libstdc++ testsuite. > > David, this is first of the AIX fixes. > It makes aliases to be output after thunks so they are not silently > miscompiled > by the assembler. I checked and the other ordering issue was actually > Solaris linker not liking thunks before functions (that is a pity, because > thunk just before function desn't need the tail jump: something I still want > to get right, but incrementally). > > Bootstrapped/regtested on AIX, comitted. > > Honza > > * cgraphunit.c (assemble_thunks_and_aliases): Expand thunks before > outputting aliases. > > Index: cgraphunit.c > =================================================================== > --- cgraphunit.c (revision 211106) > +++ cgraphunit.c (working copy) > @@ -1718,8 +1718,8 @@ > struct cgraph_node *thunk = e->caller; > > e = e->next_caller; > + expand_thunk (thunk, true); > assemble_thunks_and_aliases (thunk);
Please add a comment explaining the order of those calls. > - expand_thunk (thunk, true); > } > else > e = e->next_caller;
