> > Unfortunately, AIX isn't the only target massively affected by your > recent patches. This all started with r210597 > > 2014-05-17 Jan Hubicka <hubi...@ucw.cz> > > * tree-pass.h (make_pass_ipa_comdats): New pass. > * timevar.def (TV_IPA_COMDATS): New timevar. > * passes.def (pass_ipa_comdats): Add. > * Makefile.in (OBJS): Add ipa-comdats.o > * ipa-comdats.c: New file. > > At that time, only Solaris 11 with gas/Solaris ld was affected: many Go > tests started failing like this: > > runtime.SetFinalizer: cannot pass * os os.file to finalizer func(* > os os.file) error > fatal error: runtime.SetFinalizer
Thanks for letting me know. THis is different transformation than one causing trouble on AIX (AIX has no comdats, so this pass does nothing). Go seems tobe quite heavy user of comdat locals produced by that patch, so I suppose they somehow break with Solaris. Comdat locals are now used by ipa-comdats, for thunks and for decloned ctors. We probably need to figure out bit more precise limitation of Solaris and either fix or add way for target to say what kind of comdat locals are not supported. Can I reproduce your setup on the compile farm? Honza > > Neither Solaris 10 (which doesn't enable comdat group due to missing ld > support for what gas emits) nor Solaris 11 with /bin/as (which has > different comdat syntax, thus emitting groups differently) were > affected. > > I didn't file a PR at that time since I had started to work with the > Solaris linker engineers to see what could be done about this on the ld > side. Unfortunately, even if this worked, it won't change the installed > base. > > Since then, the number of Go testsuite failures seems to increase daily, > now Solaris 10 is also affected. Given that sparc-sun-solaris2.10 is a > primary platform, we need to do something about this. > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University
