On Tue, Jun 10, 2014 at 2:02 PM, Jan Hubicka <hubi...@ucw.cz> wrote: >> Honza, >> >> Thanks for this patch which improves some of the G++ testsuite >> failures, but most of the libstdc++ testsuite continues to fail on >> AIX. > > Yep, I am still looking into this. Just made new alias verifier that > catches quite few nonsenses in how C++ builds thunks and same body > aliases. I am testing it on PPC now (it takes a while) >> >> This patch clearly was risky and should have been more thoroughly >> tested on non-GNU/Linux systems. All of these failures make it >> impossible to know if other failures have been introduced into the AIX >> port. >> >> I will be happy to work with you to debug these failures, but I wish >> to ask that the IPA visibility patch be reverted until AIX testsuite >> results can return to a normal state with the patch applied. > > OK, the change does redirecting of functions and variables. I will try > to figure out which of those two changes actually breaks AIX and disable > it for time being.
Honza, I am not sure that the problem is caused only by aliases and thunks. The large increase in AIX linker warnings about branches not followed by nop also worry me. Your patch was about visibility. How does the more aggressive algorithm behave on a platform that does not support visibility? Is it defaulting to hidden? If the new algorithm is being too aggressive and incorrectly converting calls from global to local, it could cause serious problems for AIX because the GOT register will not be restored. Thanks David
