On Wed, Sep 17, 2014 at 11:36 PM, Hans-Peter Nilsson <h...@bitrange.com> wrote: > On Wed, 17 Sep 2014, Hans-Peter Nilsson wrote: >> On Wed, 17 Sep 2014, Hans-Peter Nilsson wrote: >> > On Wed, 17 Sep 2014, Janne Blomqvist wrote: >> > > Oops, I forgot to update some parts in an #ifdef branch that isn't >> > > taken on my target. I'll try to find time to fix it later tonight. If >> > > you're in a hurry, just replace >> > > >> > > fstrcpy (iqp->name, iqp->name_len, u->file, u->file_len); >> > > >> > > with >> > > >> > > cf_strcpy (iqp->name, iqp->name_len, u->filename); >> > > >> > > in inquire.c. >> > >> > Thanks, build completes and I'll commit the following as obvious >> > if there are no regressions. >> >> Since there are 25 related regressions, not committed. >> There must be something else amiss too. > > On the other hand, the tree *is* broken for some ports; I'd > prefer regressions to that. So, unless you're onto this, how do > you feel about me committing the posted patch and opening a PR > for the regressions?
I committed Index: inquire.c =================================================================== --- inquire.c (revision 215337) +++ inquire.c (working copy) @@ -92,9 +92,9 @@ inquire_via_unit (st_parameter_inquire * else if (u->unit_number == options.stderr_unit) fstrcpy (iqp->name, iqp->name_len, "CONERR$", sizeof("CONERR$")); else - fstrcpy (iqp->name, iqp->name_len, u->file, u->file_len); + cf_strcpy (iqp->name, iqp->name_len, u->filename); #else - fstrcpy (iqp->name, iqp->name_len, u->file, u->file_len); + cf_strcpy (iqp->name, iqp->name_len, u->filename); #endif } as obvious (r215338). -- Janne Blomqvist