Hello Jan,

---------- Původní e-mail ----------

Od: Jan Hubicka via Gcc <gcc@gcc.gnu.org>

Komu: Martin Jambor <mjam...@suse.cz>

Datum: 25. 11. 2021 11:13:33

Předmět: Re: distinguishing gcc compilation valgrind false positives

> >

> > diff --git a/gcc/ipa-prop.h b/gcc/ipa-prop.h

> > index 42842d9466a..1d0c115465c 100644

> > --- a/gcc/ipa-prop.h

> > +++ b/gcc/ipa-prop.h

> > @@ -623,8 +623,8 @@ ipa_node_params::ipa_node_params ()

> >  : descriptors (NULL), lattices (NULL), ipcp_orig_node (NULL),

> >    known_csts (vNULL), known_contexts (vNULL), analysis_done (0),

> >    node_enqueued (0), do_clone_for_all_contexts (0), is_all_contexts_clone 
> > (0),

> > -  node_dead (0), node_within_scc (0), node_calling_single_call (0),

> > -  versionable (0)

> > +  node_dead (0), node_within_scc (0), node_is_self_scc (0),

> > +  node_calling_single_call (0), versionable (0)

> >  {

> >  }

>

> Oops, can you please commit the change to master and all active

> branches?

> OK.  To be honest I am not 100% sure if the flag is not always

> initialized later.



> Zdenek, can you, please, check if the undefined warning in ipcp goes

> away with this patch and if so, post what are the remaining ones?


I can confirm that zero-initializing node_is_self_scc prevents the 
uninitialised use warnings in incorporate_penalties (ipa-cp.c:3282)

Thanks,
Zdenek


Reply via email to