Le 22/03/2022 à 19:10, Sebastiaan Couwenberg a écrit :
On 3/21/22 19:14, Even Rouault wrote:
Other things you spotted ?

A bunch of new data (and one ini) files,
Those new data files are intended. I assume you're refering to drivers.ini ? This is intended too.
and some helper scripts like:

 frmts/grib/degrib/extract_tables.py
 frmts/grib/degrib/merge_degrib_and_wmo_tables.py
for the sake of simplicity, I'd would just keep them in the tarball, even if not used during the build.

There doesn't seem to be an equivalent for:

 --with-threads
The --without-thread configuration on autoconf was untested. It perhaps builds, but not sure if runtime behaviour is correct. Offering no thread support doesn't seem very useful those days.

 --with-sse
 --with-ssse3
 --with-avx

The latter three seem to only be detected whether they're available at build time, this is somewhat problematic for distribution packages where the system building it won't be the same as the ones running it.

Those builds flags aren't necessary. The build system indeed does detect if the compiler supports SSE3 or AVX, and builds separate object files that can use those instruction sets, but they are only used at runtime if the intruction set is available. Hence you can do a generic binary that will run everywhere.

If I remember well the reason for those flags, it was because some (older?) Solaris version flagged a whole binary as requiring AVX, as soon as an object file with AVX was included in it. We'll see if there's a future need to be able to re-introduce such flags, but that doesn't seem very compelling for now.


Also no GDAL_USE_GRASS to disable it explicitly like --with-grass=no.

I tried to raise the status of the GRASS plugin and its future some time ago. A potential option would be to move it to an external repository, due to the cyclic dependency of GDAL and GRASS, but nobody jumped to take action. I believe we should just completely disable CMake build support for it for now, and people would just use the standalone autoconf script that goes with the tarball of the plugin.

Even


--
http://www.spatialys.com
My software is free, but my time generally not.

_______________________________________________
gdal-dev mailing list
gdal-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/gdal-dev

Reply via email to