Hi Patrick, El mié, 13-12-2006 a las 18:00 +0100, Patrick Bernaud escribió: [snip] > > [...] > > Patrick, I feel there is a lack of communication here. This is the first > > time I hear any technical comment (i.e.: more than "this is not > > working") about this patch since I started it (long before the transition > > from noweb to plain C). > > May I remind you that I reported the problem with stretching the lines > and made comments on the SELECTION type. Correct me if I am wrong but > so far I have been the only one to review and post comments on this > code.
You are correct. I don't forgot. I meant this is the first time we talk about how the code works. The stretching problem is a bug, and I consider the SELECTION type like a style comment. > When I reported the problem with stretching when moving objects I > looked at how I could help on this particular point and did not > found. I was short on time and it had been put in mid air until the > very beginning of December. That is when I found the undo problem and > its consequences. > > Since this time I have been trying to rewrite this part of your branch > to avoid it. > > To anyone on this list it looks as if everything was OK until I > reported the problems (I agree that some of them are older than the > branch and therefore not your responsability). > > Please understand that if I had not had a working alternative I would > have shut up and let your branch be merged as it is. All in all it > manages to do what we want. I don't want you to shut up. I'd like you emailed a "I see these problems" when you noticed them, and maybe some discussion about how can it be improved where all people (including me) could be able to participate. You don't need to have a working proposal just to say you don't like using the undo functions. Your diffs are quite huge. Could you write a little brief explaining how the move and copy actions are handled with your changes? Thanks, Carlos _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
