Peter Clifton writes: > [...] > I'm sorry about that, they are not completely in sync: > > Added new function world_get_single_object_bounds to calculate > the bounds of a single object, and make world_get_complex_bounds > call it. > > Revision Changes Path > 1.28 +63 -27 eda/geda/gaf/libgeda/src/o_complex_basic.c > > That commit may cause you grief. It shouldn't be insurmountable though. > There may be others.
The question is not if this in surmountable or not. By now you know my opinion. The question in the first place is WTF are these functions doing here? Where is the screen coords get_bounds function for complex? And believe it or not they are likely to be merged as is in HEAD. > [...] > More importantly, the order of changes is far less logical, and is more > likely to have introduced bugs. The noscreen changes opened up a range > of refactoring possibilities which make more sense being applied after > the noscreen changes. Really apart from the get_bounds problem (the commit you mention and the changes on prototypes to work on objects) and the changes on function casts by Dan in HEAD (considering you are rebasing on HEAD) there is not much conflicts. > [...] > > On this particular point please ask Peter TB Brett to forward you my > > answer to his first private message on this matter. > > I asked, but he doesn't have the message any more (some inbox problem > after a power failure). If you have any comments for me, please send. > (Or perhaps re-send Peter B the message you would like him to forward). I will send it to you. Patrick _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
