> On 2011-07-20 19:05:50, Ali Saidi wrote: > > src/python/m5/params.py, line 702 > > <http://reviews.m5sim.org/r/803/diff/1/?file=13435#file13435line702> > > > > Is this clearer than [24,16,8,0]?
Heh, I didn't notice that, but I must agree that Ali's version is better (and shorter). You could even use a tuple instead of a list to make it faster! :P - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/803/#review1427 ----------------------------------------------------------- On 2011-07-20 15:52:08, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/803/ > ----------------------------------------------------------- > > (Updated 2011-07-20 15:52:08) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > params.py: enhance IpAddress param handling > > Print IpAddress params in dot notation for readability. > Properly compare IpAddress objects (by value and not object identity). > > > Diffs > ----- > > src/python/m5/params.py 7f49e6a176b8 > > Diff: http://reviews.m5sim.org/r/803/diff > > > Testing > ------- > > a tad > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
