----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/803/ -----------------------------------------------------------
(Updated 2011-07-21 11:30:35.441614) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Changes ------- Updated to use Ali's shorter brute-force byte offset list. Fixed bug where comparison with inappropriate strings caused a ValueError rather than just returning False. Extended to handle IpAddress subclasses too. Summary (updated) ------- params.py: enhance IpAddress param handling Print IpAddress params in dot notation for readability. Properly compare IpAddress objects (by value and not object identity). Also fix up derived param classes (IpNetmask and IpWithPort) similarly. Diffs ----- src/python/m5/params.py 7f49e6a176b8 Diff: http://reviews.m5sim.org/r/803/diff Testing ------- a tad Thanks, Steve _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
