----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/803/#review1430 -----------------------------------------------------------
Ship it! - Nathan On 2011-07-21 11:30:35, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/803/ > ----------------------------------------------------------- > > (Updated 2011-07-21 11:30:35) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > params.py: enhance IpAddress param handling > > Print IpAddress params in dot notation for readability. > Properly compare IpAddress objects (by value and not object identity). > Also fix up derived param classes (IpNetmask and IpWithPort) > similarly. > > > Diffs > ----- > > src/python/m5/params.py 7f49e6a176b8 > > Diff: http://reviews.m5sim.org/r/803/diff > > > Testing > ------- > > a tad > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
