> On Feb. 2, 2012, 9:54 a.m., Steve Reinhardt wrote: > > src/python/m5/params.py, line 1559 > > <http://reviews.gem5.org/r/1002/diff/1/?file=21242#file21242line1559> > > > > I'm not too fond of just using the bare port name here, as there is > > still potential for name/keyword conflicts beyond 'default', plus it's not > > as meaningful a name as it could be. Why not something like > > 'port_${{self.name}}_connection_count'? > > > > Also, do you envision passing more than the connection count > > eventually? If so, it might be worth putting a struct here even if it only > > contains an int for now.
I've made the change as suggested (see the diff), and I must say I'm inclined to drop the "port_" prefix. What do you say? When it comes to adding more information, right now I don't see the need. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1002/#review2058 ----------------------------------------------------------- On Feb. 9, 2012, 11:46 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1002/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2012, 11:46 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Pass the ports from Python to C++ using the Swig params > > This patch adds basic information about the ports in the parameter > classes to be passed from the Python world to the corresponding C++ > object. Currently, the only information passed is the number of > connected peers, which for a Port is either 0 or 1, and for a > VectorPort reflects the size of the VectorPort. The default port of > the bus had to be renamed to avoid using the name "default" as a field > in the parameter class. It is possible to extend the Swig'ed > information further and add e.g. a pair with a description and size. > > > Diffs > ----- > > src/python/m5/SimObject.py 4f2ad221ae32 > src/python/m5/params.py 4f2ad221ae32 > > Diff: http://reviews.gem5.org/r/1002/diff/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
