> On April 1, 2012, 11:25 a.m., Andreas Hansson wrote: > > No comments? It's not very controversial, but some feedback would be much > > appreciated. Thanks.
Given that this is only used to get all the memories in the system, can we agree on this without any name changes? Nate, any suggestions, or are you happy with this? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1112/#review2395 ----------------------------------------------------------- On March 21, 2012, 10:08 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1112/ > ----------------------------------------------------------- > > (Updated March 21, 2012, 10:08 a.m.) > > > Review request for Default. > > > Description > ------- > > Python: Make the All proxy traverse SimObject children as well > > This patch changes the behaviour of the All proxy parameter to not > only consider the direct children, but also do a pre-order depth-first > traversal of the object tree and append all results from the > children. > > This is used in a later patch to find all the memories in the system, > independent of where they are located in the hierarchy. > > > Diffs > ----- > > src/python/m5/SimObject.py c739a3a829f5 > > Diff: http://reviews.gem5.org/r/1112/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
