----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1112/#review2430 -----------------------------------------------------------
Ship it! Agreed, if the All proxy is used only in one place for one purpose, and this change makes it suit that purpose better, then there's no reason not to accept it. It seems a little odd that there's no change in documentation to go along with this though... is there a comment somewhere that needs to be updated to reflect the new semantics? Heading off on a tangent to dreamland... it would be cool if we could integrate code and wiki changes so that features and their associated documentation could be reviewed and versioned together, and of course feature changes could be reviewed and accepted only if suitable documentation updates were included. Not today, though. - Steve Reinhardt On March 21, 2012, 10:08 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1112/ > ----------------------------------------------------------- > > (Updated March 21, 2012, 10:08 a.m.) > > > Review request for Default. > > > Description > ------- > > Python: Make the All proxy traverse SimObject children as well > > This patch changes the behaviour of the All proxy parameter to not > only consider the direct children, but also do a pre-order depth-first > traversal of the object tree and append all results from the > children. > > This is used in a later patch to find all the memories in the system, > independent of where they are located in the hierarchy. > > > Diffs > ----- > > src/python/m5/SimObject.py c739a3a829f5 > > Diff: http://reviews.gem5.org/r/1112/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
