----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1667/#review4615 -----------------------------------------------------------
SConstruct <http://reviews.gem5.org/r/1667/#comment4338> I'll push http://reviews.gem5.org/r/1970/ which takes care of this src/SConscript <http://reviews.gem5.org/r/1667/#comment4339> What is causing this to pop up? src/python/m5/SimObject.py <http://reviews.gem5.org/r/1667/#comment4340> Very minor, but could we move this to after the cxx_.* lines? src/python/m5/simulate.py <http://reviews.gem5.org/r/1667/#comment4341> Sporadic whitespace src/python/m5/simulate.py <http://reviews.gem5.org/r/1667/#comment4343> Could you add a line why this has moved here? src/python/swig/core.i <http://reviews.gem5.org/r/1667/#comment4342> Sporadic whitespace src/python/swig/event.i <http://reviews.gem5.org/r/1667/#comment4344> Perhaps I'm missing something here, but how come the Event is no longer an Event? :-) src/python/swig/event.i <http://reviews.gem5.org/r/1667/#comment4345> whitespace src/sim/eventq.hh <http://reviews.gem5.org/r/1667/#comment4346> Unrelated change? src/sim/eventq.hh <http://reviews.gem5.org/r/1667/#comment4347> All these unrelated? src/sim/eventq.hh <http://reviews.gem5.org/r/1667/#comment4348> Is a list a good choice here? src/sim/sim_events.hh <http://reviews.gem5.org/r/1667/#comment4349> const? src/sim/sim_events.hh <http://reviews.gem5.org/r/1667/#comment4350> const? Looks great! Some minor questions and concerns. - Andreas Hansson On Aug. 19, 2013, 11:59 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1667/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 11:59 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9841:5985e0c89872 > --------------------------- > sim: simulate with multiple event queues > This patch extends the patch Steve posted on the reviewboard (846). The patch > updated with all the changes that have taken place over last 15 months. Code > has been added so as actually carry out a quantum-based parallel simulation. > > The patch was tested in two different configurations: > 1. ruby_network_test.py: in this simulation L1 cache controllers receive > requests from the cpu. The requests are replied to immediately without > any communication taking place with any other level. > 2. twosys-tsunami-simple-atomic: this configuration simulates a client-server > system which are connected by an ethernet link. > > We still lack the ability to communicate using message buffers or ports. But > other things like simulation start and end, synchronizing after every quantum > seem to be working. > > > Diffs > ----- > > SConstruct 43d22d746e7a > src/SConscript 43d22d746e7a > src/base/barrier.hh PRE-CREATION > src/cpu/base.cc 43d22d746e7a > src/dev/etherlink.cc 43d22d746e7a > src/python/m5/SimObject.py 43d22d746e7a > src/python/m5/event.py 43d22d746e7a > src/python/m5/main.py 43d22d746e7a > src/python/m5/simulate.py 43d22d746e7a > src/python/swig/core.i 43d22d746e7a > src/python/swig/event.i 43d22d746e7a > src/sim/Root.py 43d22d746e7a > src/sim/SConscript 43d22d746e7a > src/sim/core.hh 43d22d746e7a > src/sim/debug.cc 43d22d746e7a > src/sim/eventq.hh 43d22d746e7a > src/sim/eventq.cc 43d22d746e7a > src/sim/eventq_impl.hh 43d22d746e7a > src/sim/global_event.hh PRE-CREATION > src/sim/global_event.cc PRE-CREATION > src/sim/root.cc 43d22d746e7a > src/sim/serialize.hh 43d22d746e7a > src/sim/serialize.cc 43d22d746e7a > src/sim/sim_events.hh 43d22d746e7a > src/sim/sim_events.cc 43d22d746e7a > src/sim/sim_exit.hh 43d22d746e7a > src/sim/sim_object.cc 43d22d746e7a > src/sim/simulate.hh 43d22d746e7a > src/sim/simulate.cc 43d22d746e7a > src/sim/stat_control.cc 43d22d746e7a > > Diff: http://reviews.gem5.org/r/1667/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
