> On Aug. 20, 2013, 12:42 p.m., Andreas Hansson wrote: > > SConstruct, line 640 > > <http://reviews.gem5.org/r/1667/diff/7/?file=37125#file37125line640> > > > > I'll push http://reviews.gem5.org/r/1970/ which takes care of this
Ok, I'll drop this from the patch. > On Aug. 20, 2013, 12:42 p.m., Andreas Hansson wrote: > > src/SConscript, line 899 > > <http://reviews.gem5.org/r/1667/diff/7/?file=37126#file37126line899> > > > > What is causing this to pop up? Nothing on RHEL 6. May be some OS X issue. > On Aug. 20, 2013, 12:42 p.m., Andreas Hansson wrote: > > src/python/m5/simulate.py, line 150 > > <http://reviews.gem5.org/r/1667/diff/7/?file=37133#file37133line150> > > > > Could you add a line why this has moved here? I am unable to recall exactly. I think things were going wrong if no simulation took place. The function stats.dump is called if no simulation has taken place. This function calls curTick() which now depends on the thread-local event queue. I think queues are not allocated in some case. The function stats.dump would therefore crash. I think we should not add this explaination to the code. > On Aug. 20, 2013, 12:42 p.m., Andreas Hansson wrote: > > src/sim/eventq.hh, line 347 > > <http://reviews.gem5.org/r/1667/diff/7/?file=37140#file37140line347> > > > > Unrelated change? Just the formatting is being change. > On Aug. 20, 2013, 12:42 p.m., Andreas Hansson wrote: > > src/sim/eventq.hh, line 471 > > <http://reviews.gem5.org/r/1667/diff/7/?file=37140#file37140line471> > > > > Is a list a good choice here? If you are suggesting that we use a deque, I think there is no difference in time and space complexities. > On Aug. 20, 2013, 12:42 p.m., Andreas Hansson wrote: > > src/python/swig/event.i, line 85 > > <http://reviews.gem5.org/r/1667/diff/7/?file=37135#file37135line85> > > > > Perhaps I'm missing something here, but how come the Event is no longer > > an Event? :-) The Event class was split, some parts were moved to the EventBase class. The class GlobalSimLoopExitEvent is derived from the class GlobalEvent which is derived from the EventBase class. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1667/#review4615 ----------------------------------------------------------- On Aug. 19, 2013, 11:59 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1667/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 11:59 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9841:5985e0c89872 > --------------------------- > sim: simulate with multiple event queues > This patch extends the patch Steve posted on the reviewboard (846). The patch > updated with all the changes that have taken place over last 15 months. Code > has been added so as actually carry out a quantum-based parallel simulation. > > The patch was tested in two different configurations: > 1. ruby_network_test.py: in this simulation L1 cache controllers receive > requests from the cpu. The requests are replied to immediately without > any communication taking place with any other level. > 2. twosys-tsunami-simple-atomic: this configuration simulates a client-server > system which are connected by an ethernet link. > > We still lack the ability to communicate using message buffers or ports. But > other things like simulation start and end, synchronizing after every quantum > seem to be working. > > > Diffs > ----- > > SConstruct 43d22d746e7a > src/SConscript 43d22d746e7a > src/base/barrier.hh PRE-CREATION > src/cpu/base.cc 43d22d746e7a > src/dev/etherlink.cc 43d22d746e7a > src/python/m5/SimObject.py 43d22d746e7a > src/python/m5/event.py 43d22d746e7a > src/python/m5/main.py 43d22d746e7a > src/python/m5/simulate.py 43d22d746e7a > src/python/swig/core.i 43d22d746e7a > src/python/swig/event.i 43d22d746e7a > src/sim/Root.py 43d22d746e7a > src/sim/SConscript 43d22d746e7a > src/sim/core.hh 43d22d746e7a > src/sim/debug.cc 43d22d746e7a > src/sim/eventq.hh 43d22d746e7a > src/sim/eventq.cc 43d22d746e7a > src/sim/eventq_impl.hh 43d22d746e7a > src/sim/global_event.hh PRE-CREATION > src/sim/global_event.cc PRE-CREATION > src/sim/root.cc 43d22d746e7a > src/sim/serialize.hh 43d22d746e7a > src/sim/serialize.cc 43d22d746e7a > src/sim/sim_events.hh 43d22d746e7a > src/sim/sim_events.cc 43d22d746e7a > src/sim/sim_exit.hh 43d22d746e7a > src/sim/sim_object.cc 43d22d746e7a > src/sim/simulate.hh 43d22d746e7a > src/sim/simulate.cc 43d22d746e7a > src/sim/stat_control.cc 43d22d746e7a > > Diff: http://reviews.gem5.org/r/1667/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
