----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2153/#review4891 -----------------------------------------------------------
src/mem/ruby/system/RubyPort.cc <http://reviews.gem5.org/r/2153/#comment4561> I think there is some problem here. You are setting source to 0 here, but in review 2039, you set source to the id of the port that received this request packet. Which one do you want to go with? - Nilay Vaish On Jan. 23, 2014, 5:33 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2153/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 5:33 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10022:6be85e163055 > --------------------------- > ruby: Add bridges between RubyPort and NoncoherentBus > > This patch adds bridges between the PIO port of the Ruby sequencers > (based on RubyPort) and the PIO bus (based on NoncoherentBus). Both > the RubyPort and the bus are multiplexing components, and as such, > they should be connected by a bridge, similar to the memory bus and > PIO bus in the classic memory system. > > The patch http://reviews.gem5.org/r/2039/ depends on this one. > > > Diffs > ----- > > configs/ruby/MESI_Three_Level.py a362694dda2d > configs/ruby/MESI_Two_Level.py a362694dda2d > configs/ruby/MI_example.py a362694dda2d > configs/ruby/MOESI_CMP_directory.py a362694dda2d > configs/ruby/MOESI_CMP_token.py a362694dda2d > configs/ruby/MOESI_hammer.py a362694dda2d > src/mem/ruby/system/RubyPort.cc a362694dda2d > > Diff: http://reviews.gem5.org/r/2153/diff/ > > > Testing > ------- > > All regressions pass (with some minor stats changes) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
