----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2153/#review4893 -----------------------------------------------------------
I think we should drop this patch. Two reasons: * I need to add port connections where the ruby port act as the slave side and the piobus acts as the master side. This means that the in-between bridge will have to inform the piobus of the address ranges the bridge will cater to. Those address ranges are not known to the ruby port until the attached interrupt controllers pass that information. But the bridge assumes that this information is available while the object is being constructed and the piobus is informed of the ranges in the init() function of the bridge. We cannot assign some big default range (as being done for most bridges used) since one bridge for each ruby port needs to be added. * In future we will severe this direct connection between ruby port and the piobus. I think we can simply retain the current setup of connecting things directly to the piobus. - Nilay Vaish On Jan. 23, 2014, 5:33 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2153/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 5:33 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10022:6be85e163055 > --------------------------- > ruby: Add bridges between RubyPort and NoncoherentBus > > This patch adds bridges between the PIO port of the Ruby sequencers > (based on RubyPort) and the PIO bus (based on NoncoherentBus). Both > the RubyPort and the bus are multiplexing components, and as such, > they should be connected by a bridge, similar to the memory bus and > PIO bus in the classic memory system. > > The patch http://reviews.gem5.org/r/2039/ depends on this one. > > > Diffs > ----- > > configs/ruby/MESI_Three_Level.py a362694dda2d > configs/ruby/MESI_Two_Level.py a362694dda2d > configs/ruby/MI_example.py a362694dda2d > configs/ruby/MOESI_CMP_directory.py a362694dda2d > configs/ruby/MOESI_CMP_token.py a362694dda2d > configs/ruby/MOESI_hammer.py a362694dda2d > src/mem/ruby/system/RubyPort.cc a362694dda2d > > Diff: http://reviews.gem5.org/r/2153/diff/ > > > Testing > ------- > > All regressions pass (with some minor stats changes) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
