----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2313/#review5338 -----------------------------------------------------------
src/arch/x86/tlb.cc <http://reviews.gem5.org/r/2313/#comment4848> Could you get rid of this code duplication before committing? I'd suggest that you rewrite it something like this: if (m5opRange) { ... } else if (FullSystem) { ... } src/cpu/kvm/base.hh <http://reviews.gem5.org/r/2313/#comment4849> Is this supposed to be here? src/sim/pseudo_inst.cc <http://reviews.gem5.org/r/2313/#comment4850> I think these are reserved for temporary user extensions, so you should probably use another range. I'd suggest that you just number the functions as 0x60 and 0x61 and make a note that the 0x60-0x6f range is intended for SE mode calls. Looks good overall, but there are some minor issues I'd like you to look into. As far as I'm concerned, you can go ahead and commit this patch when you have fixed them. - Andreas Sandberg On Sept. 16, 2014, 4:34 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2313/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 4:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10301:9a09f71f7234 > --------------------------- > kvm, x86: Adding support for SE mode execution > This patch adds methods in KvmCPU model to handle KVM exits caused by syscall > instructions and page faults. These types of exits will be encountered if > KvmCPU is run in SE mode. > > > Diffs > ----- > > src/arch/x86/tlb.cc bec0c5ffc3237096570fe4c802aeb37e1e396d1b > src/arch/x86/utility.cc bec0c5ffc3237096570fe4c802aeb37e1e396d1b > src/cpu/kvm/base.hh bec0c5ffc3237096570fe4c802aeb37e1e396d1b > src/cpu/kvm/base.cc bec0c5ffc3237096570fe4c802aeb37e1e396d1b > src/sim/pseudo_inst.hh bec0c5ffc3237096570fe4c802aeb37e1e396d1b > src/sim/pseudo_inst.cc bec0c5ffc3237096570fe4c802aeb37e1e396d1b > src/sim/system.cc bec0c5ffc3237096570fe4c802aeb37e1e396d1b > util/m5/m5ops.h bec0c5ffc3237096570fe4c802aeb37e1e396d1b > > Diff: http://reviews.gem5.org/r/2313/diff/ > > > Testing > ------- > > Quick regressions passed. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
