----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2313/ -----------------------------------------------------------
(Updated Nov. 20, 2014, 12:36 a.m.) Review request for Default. Changes ------- Addressed all the raised issues. In addition, it seems that exitGroup syscall has been changed such that each thread context is halted. In the case of KvmCPU, BaseKVMCPU::haltContext calls BaseKVMCPU::suspendContext and, in this case, the _status can be something different than Running inside suspendContext. I don't see a strong reason to have a haltContext implementation independent of suspendContext, as the difference between the 2 methods will be just one assert. Therefore I have broaden a bit the assert condition in suspendContext. Repository: gem5 Description (updated) ------- Changeset 10548:8f97f4918e7c --------------------------- kvm, x86: Adding support for SE mode execution This patch adds methods in KvmCPU model to handle KVM exits caused by syscall instructions and page faults. These types of exits will be encountered if KvmCPU is run in SE mode. Diffs (updated) ----- src/arch/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/alpha/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/arm/pseudo_inst.hh PRE-CREATION src/arch/generic/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/generic/pseudo_inst.hh PRE-CREATION src/arch/generic/pseudo_inst.cc PRE-CREATION src/arch/mips/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/power/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/sparc/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/x86/SConscript 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/x86/pseudo_inst.hh PRE-CREATION src/arch/x86/pseudo_inst.cc PRE-CREATION src/arch/x86/tlb.cc 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/arch/x86/utility.cc 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/cpu/kvm/base.cc 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/sim/pseudo_inst.cc 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 src/sim/system.cc 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 util/m5/m5ops.h 288eb5ee4b0026d0cc1f02ec31748e0eaac06bc3 Diff: http://reviews.gem5.org/r/2313/diff/ Testing ------- Quick regressions passed. Thanks, Alexandru Dutu _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
