----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7429 -----------------------------------------------------------
src/mem/request.hh (line 89) <http://reviews.gem5.org/r/3180/#comment6267> Should not be needed. There is space. src/mem/request.hh (line 664) <http://reviews.gem5.org/r/3180/#comment6268> No command has both set. Seems odd to check... src/mem/request.hh (line 667) <http://reviews.gem5.org/r/3180/#comment6269> This seems strange to me. We rely on the flags being fixed. I don't see why you would want to change such a fundamental assumption. - Andreas Hansson On Oct. 30, 2015, 9:50 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3180/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11186:915989ed4b8a > --------------------------- > mem: add request types for acquire and release > > Add support for acquire and release requests. These synchronization > operations > are commonly supported by several modern instruction sets. > > > Diffs > ----- > > src/mem/packet.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/packet.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/request.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3180/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
