----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7622 -----------------------------------------------------------
src/mem/request.hh (line 158) <http://reviews.gem5.org/r/3180/#comment6572> If you make these 0x00020000 and 0x00040000 they could be consecutive. Could you please also elaborate on the description of these flags, what promises/requirements are imposed etc. src/mem/request.hh (line 664) <http://reviews.gem5.org/r/3180/#comment6571> This seems odd. No packet type has both set. I am still not really understanding the request and the packet part. How are the two related (are they)? - Andreas Hansson On Nov. 19, 2015, 10:50 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3180/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 10:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11225:9e0fa0306f8b > --------------------------- > mem: add request types for acquire and release > > Add support for acquire and release requests. These synchronization > operations > are commonly supported by several modern instruction sets. > > > Diffs > ----- > > src/mem/packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/mem/packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/mem/request.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > > Diff: http://reviews.gem5.org/r/3180/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
