> On Sept. 21, 2015, 3:09 p.m., Nilay Vaish wrote: > > configs/common/CacheConfig.py, line 56 > > <http://reviews.gem5.org/r/3031/diff/1/?file=48967#file48967line56> > > > > Why do we need this?
Yep, not needed - you won't see this in the updated patch. > On Sept. 21, 2015, 3:09 p.m., Nilay Vaish wrote: > > configs/common/Simulation.py, line 459 > > <http://reviews.gem5.org/r/3031/diff/1/?file=48971#file48971line459> > > > > Separate function please. This file is already very unruly. Agree. Created a new example file for trace replay - hopefully setting a good example. :) > On Sept. 21, 2015, 3:09 p.m., Nilay Vaish wrote: > > configs/example/fs.py, lines 217-248 > > <http://reviews.gem5.org/r/3031/diff/1/?file=48972#file48972line217> > > > > I would prefer a separate function here. And I think the trace file > > paths should be obtained from options. I think we can reuse the options > > that are used to supply the trace files to the trace cpu. Adopted both your suggestions. > On Sept. 21, 2015, 3:09 p.m., Nilay Vaish wrote: > > configs/example/se.py, lines 163-173 > > <http://reviews.gem5.org/r/3031/diff/1/?file=48973#file48973line163> > > > > Other than the check on the number of cpus, I would want to rely on the > > trace cpu to make sure that the trace files have been provided. So I would > > not do any checking on these files here. Fixed. > On Sept. 21, 2015, 3:09 p.m., Nilay Vaish wrote: > > configs/example/se.py, lines 207-232 > > <http://reviews.gem5.org/r/3031/diff/1/?file=48973#file48973line207> > > > > It seems like this code is common to both fs and se.py. We should > > write this code as a function to some other file, may be to CpuConfig.py > > and invoke the function in both se and fs.py. Fixed. - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3031/#review7230 ----------------------------------------------------------- On Aug. 11, 2015, 9:05 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3031/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 9:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds changes to the configuration scripts to support elastic > tracing and replay. > > The patch adds a command line option to enable elastic tracing in SE mode > and FS mode. When enabled the Elastic Trace cpu probe is attached to O3CPU > and a few O3 CPU parameters are tuned. The Elastic Trace probe writes out > both instruction fetch and data dependency traces. The patch also enables > configuring the TraceCPU to replay traces using the SE and FS script. > > The replay run is designed to resume from checkpoint using atomic cpu to > restore state keeping it consistent with FS run flow. It then switches to > TraceCPU to replay the input traces. > > > Diffs > ----- > > src/cpu/trace/trace_cpu.hh PRE-CREATION > src/cpu/trace/trace_cpu.cc PRE-CREATION > configs/common/CacheConfig.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > configs/common/CpuConfig.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > configs/common/MemConfig.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > configs/common/Options.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > configs/common/Simulation.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > configs/example/fs.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > configs/example/se.py b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/trace/TraceCPU.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3031/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
