> On Nov. 6, 2015, 7:50 a.m., Nilay Vaish wrote: > > configs/example/etrace_replay.py, lines 107-109 > > <http://reviews.gem5.org/r/3031/diff/2/?file=51462#file51462line107> > > > > I think these are the only lines that extra > > over what se.py has. Why not just move these to se.py? > > Radhika Jagtap wrote: > There were a few code blocks where cpu or workload was being configured > for se and fs. That code did not apply for a trace-based cpu. So, in the > previous version of this patch I had inserted a check a all these points - if > cpu type is not trace then do these code blocks else do trace cpu counterpart > or do nothing.
I saw the first version of the patch. I am actually fine with adding a check in se.py and assiging these two trace file variables. Since the TraceCPU inherits from BaseCPU, you do not even need to worry about some code being not applicable to the TraceCPU since the BaseCPU class will take care of it. It is sort of similar to when we start from a checkpoint we still need to specify everything. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3031/#review7520 ----------------------------------------------------------- On Nov. 5, 2015, 9:13 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3031/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 9:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds changes to the configuration scripts to support elastic > tracing and replay. > > The patch adds a command line option to enable elastic tracing in SE mode > and FS mode. When enabled the Elastic Trace cpu probe is attached to O3CPU > and a few O3 CPU parameters are tuned. The Elastic Trace probe writes out > both instruction fetch and data dependency traces. The patch also enables > configuring the TraceCPU to replay traces using the SE and FS script. > > The replay run is designed to resume from checkpoint using atomic cpu to > restore state keeping it consistent with FS run flow. It then switches to > TraceCPU to replay the input traces. > > > Diffs > ----- > > src/cpu/trace/TraceCPU.py PRE-CREATION > src/cpu/trace/trace_cpu.hh PRE-CREATION > src/cpu/trace/trace_cpu.cc PRE-CREATION > configs/example/fs.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/example/se.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/CpuConfig.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/MemConfig.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/Options.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/Simulation.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/dram/sweep.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/example/etrace_replay.py PRE-CREATION > configs/common/CacheConfig.py 854e61d5390e3bee8864848465fab311e95b9759 > > Diff: http://reviews.gem5.org/r/3031/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
