> On Nov. 6, 2015, 7:50 a.m., Nilay Vaish wrote: > > src/cpu/trace/trace_cpu.hh, lines 183-190 > > <http://reviews.gem5.org/r/3031/diff/2/?file=51466#file51466line183> > > > > Merge with patch on trace cpu. > > Radhika Jagtap wrote: > The plan is to merge all the elastic traces patches and commit in a > single changeset. > > Nilay Vaish wrote: > Do you mean from reviews 3026-3031 are going to be committed as one > single changeset? > Is it required due to some dependency? I somehow prefer the current > division into > 5/6 different patches.
Hi Nilay, I had a chat with folks here and realised I was under the wrong impression. Yes, the patches they way they are organised will be committed. There are 8 in total and you have reviewed 6 of them. Does the division for the 6 seem reasonable? Each patch adds a new independent functionality applies and passess tests individually. - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3031/#review7520 ----------------------------------------------------------- On Nov. 5, 2015, 9:13 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3031/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 9:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds changes to the configuration scripts to support elastic > tracing and replay. > > The patch adds a command line option to enable elastic tracing in SE mode > and FS mode. When enabled the Elastic Trace cpu probe is attached to O3CPU > and a few O3 CPU parameters are tuned. The Elastic Trace probe writes out > both instruction fetch and data dependency traces. The patch also enables > configuring the TraceCPU to replay traces using the SE and FS script. > > The replay run is designed to resume from checkpoint using atomic cpu to > restore state keeping it consistent with FS run flow. It then switches to > TraceCPU to replay the input traces. > > > Diffs > ----- > > src/cpu/trace/TraceCPU.py PRE-CREATION > src/cpu/trace/trace_cpu.hh PRE-CREATION > src/cpu/trace/trace_cpu.cc PRE-CREATION > configs/example/fs.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/example/se.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/CpuConfig.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/MemConfig.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/Options.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/common/Simulation.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/dram/sweep.py 854e61d5390e3bee8864848465fab311e95b9759 > configs/example/etrace_replay.py PRE-CREATION > configs/common/CacheConfig.py 854e61d5390e3bee8864848465fab311e95b9759 > > Diff: http://reviews.gem5.org/r/3031/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
