----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/#review7655 -----------------------------------------------------------
src/sim/pseudo_inst.cc (line 459) <http://reviews.gem5.org/r/3228/#comment6597> rather than magic values why not have initparam pass a string key and get value. That will mean less annoying issues in the future with two parties using the same number before committing the code. This is the same issue that was recently fixed with the checkpoint versioniong, we probably shouldn't repeat it here. - Ali Saidi On Nov. 19, 2015, 5:44 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3228/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 5:44 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Distributed gem5 is the result of the convergence effort between multi-gem5 > and pd-gem5 (from Univ. of Wisconsin). It relies on the base multi-gem5 > infrastructure for packet forwarding, synchronisation and checkpointing but > combines those with the elaborated network switch model from pd-gem5. > > > Diffs > ----- > > src/dev/multi_iface.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/multi_packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/multi_packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/tcp_iface.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/tcp_iface.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/sim/global_event.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/sim/initparam_keys.hh PRE-CREATION > src/sim/pseudo_inst.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > util/multi/Makefile c0ea80fed78fef29ad2829b9d93e7bd568c46665 > util/multi/tcp_server.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > util/multi/tcp_server.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/multi_etherlink.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/multi_etherlink.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/multi_iface.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/Ethernet.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/SConscript c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/dist_etherlink.hh PRE-CREATION > src/dev/dist_etherlink.cc PRE-CREATION > src/dev/dist_iface.hh PRE-CREATION > src/dev/dist_iface.cc PRE-CREATION > src/dev/dist_packet.hh PRE-CREATION > src/dev/etherpkt.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/dev/etherpkt.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > > Diff: http://reviews.gem5.org/r/3228/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
