> On Dec. 31, 2015, 5:09 a.m., Steve Reinhardt wrote:
> > Qre the dist_*.{cc,hh} files basically just renames (with internal symbol
> > renames) of the equivalent multi_* files, or are there significant
> > differences? Were they renamed with 'hg rename/mv'?
> >
> > I still haven't had time to look at this closely, but I figured I'd nitpick
> > a few style issues while I'm at it.
> >
> > Given that it's clearly an improvement over the status quo (since it
> > includes input from pd-gem5) I don't have a problem with committing first
> > and addressing any issues I run across later, once the style issues are
> > addressed.
Steve,
there are significant differences.
Originally they were not created with rename/mv but that has been fixed.
- Curtis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3228/#review7794
-----------------------------------------------------------
On Jan. 7, 2016, 9:58 p.m., Curtis Dunham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3228/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 9:58 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Distributed gem5 is the result of the convergence effort between multi-gem5
> and pd-gem5 (from Univ. of Wisconsin). It relies on the base multi-gem5
> infrastructure for packet forwarding, synchronisation and checkpointing but
> combines those with the elaborated network switch model from pd-gem5.
>
>
> Diffs
> -----
>
> src/dev/net/Ethernet.py 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/SConscript 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/etherpkt.hh 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/etherpkt.cc 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/multi_etherlink.hh 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/multi_etherlink.cc 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/multi_iface.hh 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/multi_iface.cc 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/multi_packet.hh 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/multi_packet.cc 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/tcp_iface.hh 57c340f947c719a5acc3867037d51829c3967671
> src/dev/net/tcp_iface.cc 57c340f947c719a5acc3867037d51829c3967671
> src/sim/global_event.hh 57c340f947c719a5acc3867037d51829c3967671
> src/sim/initparam_keys.hh PRE-CREATION
> src/sim/pseudo_inst.cc 57c340f947c719a5acc3867037d51829c3967671
> util/multi/Makefile 57c340f947c719a5acc3867037d51829c3967671
> util/multi/tcp_server.hh 57c340f947c719a5acc3867037d51829c3967671
> util/multi/tcp_server.cc 57c340f947c719a5acc3867037d51829c3967671
>
> Diff: http://reviews.gem5.org/r/3228/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Curtis Dunham
>
>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
