-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3228/#review7794
-----------------------------------------------------------
Qre the dist_*.{cc,hh} files basically just renames (with internal symbol
renames) of the equivalent multi_* files, or are there significant differences?
Were they renamed with 'hg rename/mv'?
I still haven't had time to look at this closely, but I figured I'd nitpick a
few style issues while I'm at it.
Given that it's clearly an improvement over the status quo (since it includes
input from pd-gem5) I don't have a problem with committing first and addressing
any issues I run across later, once the style issues are addressed.
src/dev/dist_iface.hh (line 308)
<http://reviews.gem5.org/r/3228/#comment6761>
open brace goes on following line
src/dev/tcp_iface.hh (line 83)
<http://reviews.gem5.org/r/3228/#comment6763>
open brace goes on following line
src/dev/tcp_iface.cc (line 114)
<http://reviews.gem5.org/r/3228/#comment6762>
open brace goes on following line
src/sim/initparam_keys.hh (line 53)
<http://reviews.gem5.org/r/3228/#comment6764>
open brace goes on following line
- Steve Reinhardt
On Dec. 9, 2015, 3:34 p.m., Curtis Dunham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3228/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 3:34 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Distributed gem5 is the result of the convergence effort between multi-gem5
> and pd-gem5 (from Univ. of Wisconsin). It relies on the base multi-gem5
> infrastructure for packet forwarding, synchronisation and checkpointing but
> combines those with the elaborated network switch model from pd-gem5.
>
>
> Diffs
> -----
>
> src/dev/Ethernet.py 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/SConscript 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/dist_etherlink.hh PRE-CREATION
> src/dev/dist_etherlink.cc PRE-CREATION
> src/dev/dist_iface.hh PRE-CREATION
> src/dev/dist_iface.cc PRE-CREATION
> src/dev/dist_packet.hh PRE-CREATION
> src/dev/etherpkt.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/etherpkt.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/multi_etherlink.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/multi_etherlink.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/multi_iface.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/multi_iface.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/multi_packet.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/multi_packet.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/tcp_iface.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/dev/tcp_iface.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/sim/global_event.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> src/sim/initparam_keys.hh PRE-CREATION
> src/sim/pseudo_inst.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
> util/multi/Makefile 8ed230a0b28c9422ec974c68e51aed7e41af398e
> util/multi/tcp_server.hh 8ed230a0b28c9422ec974c68e51aed7e41af398e
> util/multi/tcp_server.cc 8ed230a0b28c9422ec974c68e51aed7e41af398e
>
> Diff: http://reviews.gem5.org/r/3228/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Curtis Dunham
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
