> On May 18, 2016, 3 p.m., Gabor Dozsa wrote: > > src/dev/net/etherswitch.cc, line 87 > > <http://reviews.gem5.org/r/3465/diff/2/?file=55331#file55331line87> > > > > You can replace std::prev(fifo.end()) by fifo.rbegin() (in the next > > line, too). > > Mohammad Alian wrote: > I think we cannot use reverse pointers in std::set to erase an object. I > get error and this is my understanding after doing some google search. Please > let me know if there is still a better way to handle this.
You are right, reverse iterator would not make this simpler since erase() does not work with it. Just drop this issue please. - Gabor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3465/#review8311 ----------------------------------------------------------- On May 18, 2016, 8:09 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3465/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 8:09 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11472:2ca9b29819aa > --------------------------- > dist, dev: Fixed the packet ordering in etherswitch > This patch fixes the order that packets gets pushed into the output fifo > of etherswitch. If two packets arrive at the same tick to the etherswitch, > we sort and push them based on their source port id. > In dist-gem5 simulations, if there is no ordering inforced while two > packets arrive at the same tick, it can lead to non-deterministic simulations > > > Diffs > ----- > > src/dev/net/etherswitch.hh 954d3014f7f0 > src/dev/net/etherswitch.cc 954d3014f7f0 > > Diff: http://reviews.gem5.org/r/3465/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
