----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3465/#review8329 -----------------------------------------------------------
src/dev/net/etherswitch.cc (line 85) <http://reviews.gem5.org/r/3465/#comment7208> This DPRINTF is useful but I am still concerned a bit about hitting the pathological case when the packet is too long to go through even if the fifo is empty (regardless how may times the user application tries to re-send it). Could you please add another DPRINTF after this loop to catch that, i.e. something like: if (empty()) { DPRINTF(Ethernet, "Packet length (%d) exceeds the maximum storage capacity of port fifo (%d)", ptr->length, _maxsize); } - Gabor Dozsa On May 20, 2016, 6:39 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3465/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 6:39 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11472:80706f711d39 > --------------------------- > dist, dev: Fixed the packet ordering in etherswitch > This patch fixes the order that packets gets pushed into the output fifo > of etherswitch. If two packets arrive at the same tick to the etherswitch, > we sort and push them based on their source port id. > In dist-gem5 simulations, if there is no ordering inforced while two > packets arrive at the same tick, it can lead to non-deterministic simulations > > > Diffs > ----- > > src/dev/net/etherswitch.hh 954d3014f7f0 > src/dev/net/etherswitch.cc 954d3014f7f0 > > Diff: http://reviews.gem5.org/r/3465/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
