----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3465/#review8320 -----------------------------------------------------------
src/dev/net/etherswitch.hh (line 39) <http://reviews.gem5.org/r/3465/#comment7197> This is not needed here I think. src/dev/net/etherswitch.hh (line 40) <http://reviews.gem5.org/r/3465/#comment7198> Should this be <set> instead? src/dev/net/etherswitch.hh (line 72) <http://reviews.gem5.org/r/3465/#comment7200> Delete empty line. src/dev/net/etherswitch.cc (line 35) <http://reviews.gem5.org/r/3465/#comment7203> This include should be after etherswitch.hh and before the m5 includes according to coding styles. src/dev/net/etherswitch.cc (line 82) <http://reviews.gem5.org/r/3465/#comment7201> I think this will still create a temporary PortFifoEntry object in this form. To avoid the extra object and copy, change this to: fifo.emplace_hint(fifo.end, ptr, curTick(), senderId); src/dev/net/etherswitch.cc (line 94) <http://reviews.gem5.org/r/3465/#comment7202> Could you add an extra DPRINTF message here in case when the fifo is empty? That may be a big help to find the issue if somebody hits this by accident. - Gabor Dozsa On May 18, 2016, 8:09 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3465/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 8:09 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11472:2ca9b29819aa > --------------------------- > dist, dev: Fixed the packet ordering in etherswitch > This patch fixes the order that packets gets pushed into the output fifo > of etherswitch. If two packets arrive at the same tick to the etherswitch, > we sort and push them based on their source port id. > In dist-gem5 simulations, if there is no ordering inforced while two > packets arrive at the same tick, it can lead to non-deterministic simulations > > > Diffs > ----- > > src/dev/net/etherswitch.hh 954d3014f7f0 > src/dev/net/etherswitch.cc 954d3014f7f0 > > Diff: http://reviews.gem5.org/r/3465/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
