On Sun, Dec 26, 2010 at 10:36 AM, nathan binkert <n...@binkert.org> wrote:
> >> One other question is, should we separate out automatically generated > headers? > >> (like those for params and soon, debug flags?) If so, should I rename > them at all, > >> put them in a subdirectory (generated/params/Foo.hh), or leave them > alone? > >> Given that there is going to be a bunch of churn, we may as well do it > all at once. > > > > I don't think you should put those headers in a "generated" directory. > > That would be more cumbersome to use, and I don't think it would gain > much. > > I think I agree, though the motivation was to indicate to users that > these files were generated and that they wouldn't be able to find > them. It does lead to confusion some times. I could put them in a > separate block which I would lean towards or just sort them in with > other m5 headers. > I could go either way on the explicit directory... I think new users do get confused when some headers aren't where they expect them to be with no obvious way of knowing why, so even though I agree that it seems a little inelegant, I'm not opposed to the idea. If it's just a matter of typing, we could call the directory "gen" instead of "generated". I don't think the separate block (w/o being in a separate directory) is a good idea, since that means not only will people get confused when looking for header files, they'll get confused when we tell them their include ordering doesn't follow the style guide too. I.e., we're not adding much info, we're just introducing a new aspect that subtly relies on the same non-obvious info. Steve
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
