----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/362/#review622 -----------------------------------------------------------
Ship it! I think we've beat this to death on the mailing list. My only comment is that before it becomes part of the commit hook, please make sure that you can't throw anything at it that will cause an exception. - Ali On 2010-12-25 20:05:55, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/362/ > ----------------------------------------------------------- > > (Updated 2010-12-25 20:05:55) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > util: python implementation of a routine that will sort includes > I didn't realize that the perl version existed when I started this, > this version has a lot more features than the previous one since it will > sort and separate python, system, and m5 headers in separate groups, it > will remove duplicates, it will also convert c headers to stl headers > > > Diffs > ----- > > util/file_types.py PRE-CREATION > util/sort-includes f249937228b5 > util/sort_includes.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/362/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
