----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/367/#review611 -----------------------------------------------------------
src/mem/ruby/buffers/MessageBuffer.cc <http://reviews.m5sim.org/r/367/#comment833> Why continue to comment this out? src/mem/ruby/common/Global.cc <http://reviews.m5sim.org/r/367/#comment834> This doesn't seem like a applicable change, also aren't they equivalent? - Ali On 2011-01-04 15:02:38, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/367/ > ----------------------------------------------------------- > > (Updated 2011-01-04 15:02:38) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: get rid of ruby's Debug.hh > > Get rid of the Debug class > Get rid of ASSERT and use assert > Use DPRINTF for ProtocolTrace > > > Diffs > ----- > > configs/ruby/Ruby.py 7338bc628489 > src/mem/SConscript 7338bc628489 > src/mem/ruby/buffers/MessageBuffer.hh 7338bc628489 > src/mem/ruby/buffers/MessageBuffer.cc 7338bc628489 > src/mem/ruby/common/Debug.hh 7338bc628489 > src/mem/ruby/common/Debug.cc 7338bc628489 > src/mem/ruby/common/Debug.py 7338bc628489 > src/mem/ruby/common/Global.hh 7338bc628489 > src/mem/ruby/common/Global.cc 7338bc628489 > src/mem/ruby/common/SConscript 7338bc628489 > src/mem/ruby/common/Set.cc 7338bc628489 > src/mem/ruby/eventqueue/RubyEventQueue.cc 7338bc628489 > src/mem/ruby/filters/BulkBloomFilter.cc 7338bc628489 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 7338bc628489 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 7338bc628489 > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh 7338bc628489 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 7338bc628489 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 7338bc628489 > src/mem/ruby/network/garnet/flexible-pipeline/flit.hh 7338bc628489 > src/mem/ruby/network/simple/SimpleNetwork.cc 7338bc628489 > src/mem/ruby/network/simple/Throttle.cc 7338bc628489 > src/mem/ruby/network/simple/Topology.cc 7338bc628489 > src/mem/ruby/profiler/Profiler.hh 7338bc628489 > src/mem/ruby/profiler/Profiler.cc 7338bc628489 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 7338bc628489 > src/mem/ruby/storebuffer/storebuffer.cc 7338bc628489 > src/mem/ruby/system/RubySystem.py 7338bc628489 > src/mem/ruby/system/Sequencer.cc 7338bc628489 > src/mem/ruby/system/System.cc 7338bc628489 > src/mem/ruby/tester/DeterministicDriver.cc 7338bc628489 > src/mem/ruby/tester/RaceyDriver.cc 7338bc628489 > src/mem/ruby/tester/RaceyPseudoThread.cc 7338bc628489 > src/mem/ruby/tester/test_framework.cc 7338bc628489 > src/mem/slicc/symbols/StateMachine.py 7338bc628489 > src/mem/slicc/symbols/Type.py 7338bc628489 > > Diff: http://reviews.m5sim.org/r/367/diff > > > Testing > ------- > > This compiles and passes all of the quick regressions, but it would be nice > for a Ruby developer to take a look and see if I got rid of any useful > functionality. > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
