----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review714 -----------------------------------------------------------
src/mem/ruby/system/RubyPort.cc <http://reviews.m5sim.org/r/399/#comment979> I suggest changing Packet::getPtr() to take an optional flag like this: getPtr(bool null_ok = false) { assert(null_ok || flags.isSet(STATIC_DATA|DYNAMIC_DATA)); return (T*)data; } (assuming that data really is null when those flags are clear), then changing this section to just call getPtr<uint8_t>(true) (you might not even need the ruby_data temp anymore, I'm not sure), and you won't even need the method that you can't find a good name for :-) - Steve On 2011-01-10 15:59:13, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/399/ > ----------------------------------------------------------- > > (Updated 2011-01-10 15:59:13) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > mem: Added support for Null data packet > > The packet now identifies whether static or dynamic data has been allocated > and > is used by Ruby to determine whehter to copy the data pointer into the ruby > request. Ruby does not currently support array data. > > > Diffs > ----- > > src/mem/packet.hh 9f9e10967912 > src/mem/ruby/system/DMASequencer.cc 9f9e10967912 > src/mem/ruby/system/RubyPort.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/399/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
