> On 2011-01-10 13:54:18, Gabe Black wrote: > > src/mem/packet.hh, line 775 > > <http://reviews.m5sim.org/r/399/diff/3/?file=9462#file9462line775> > > > > You need spaces around |.
I can add a space around |, but hat is inconsistent with the rest of the file. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review708 ----------------------------------------------------------- On 2011-01-10 15:59:13, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/399/ > ----------------------------------------------------------- > > (Updated 2011-01-10 15:59:13) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > mem: Added support for Null data packet > > The packet now identifies whether static or dynamic data has been allocated > and > is used by Ruby to determine whehter to copy the data pointer into the ruby > request. Ruby does not currently support array data. > > > Diffs > ----- > > src/mem/packet.hh 9f9e10967912 > src/mem/ruby/system/DMASequencer.cc 9f9e10967912 > src/mem/ruby/system/RubyPort.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/399/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
