----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review706 -----------------------------------------------------------
Sorry I haven't plowed through all the other review requests, but where is this used in Ruby? What happens if the packet doesn't have data? Would it make sense to combine the patches that use this function with this patch? (My thought is probably so.) - Steve On 2011-01-10 11:42:35, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/399/ > ----------------------------------------------------------- > > (Updated 2011-01-10 11:42:35) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > packet: function identifying whether data has been allocated > > This function identifies whether static or dynamic data has been allocated and > is used by Ruby to determine whehter to copy the data pointer into the ruby > request. Ruby does not currently support array data. > > > Diffs > ----- > > src/mem/packet.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/399/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
