Hello Simone, In general I'm always sceptical when people point at old releases and say "this must be okay because X did it like this as well". However, in this case I agree that there are many packagers that put in an extra folder in their source archive and put those files there.
So: +1 for me Regarding the extra copyright notice. I'm not a lawyer, I just think it does not belong there. No showstopper as far as I'm concerned, but I would remove it for the next release. Greetings, Marcel On Dec 27, 2012, at 11:06 , Simone Tripodi <simonetrip...@apache.org> wrote: > Salut Marcel/all, > >> So either all of these packages are "wrong" or it seems it is >> acceptable usage. Actually I think it is fine: it is the only folder >> which becomes extracted for me everything inside this folder is >> "root". > > +1, and I'd invite you reconsidering to change the -1 vote to a +1: > inspecting the org.apache:apache:12 it clearly shows the same > structure of org.apache.onami:org.apache.onami.parent:1-incubating > > * with unzip: > > $ unzip -l apache-12-source-release.zip > Archive: apache-12-source-release.zip > Length Date Time Name > -------- ---- ---- ---- > 0 11-01-12 22:57 apache-12/ > 0 11-01-12 22:57 apache-12/src/ > 0 11-01-12 22:57 apache-12/src/site-docs/ > 0 11-01-12 22:57 apache-12/src/site-docs/apt/ > 15519 11-01-12 22:57 apache-12/pom.xml > 2759 11-01-12 22:57 apache-12/site-pom.xml > 6265 11-01-12 22:57 apache-12/src/site-docs/apt/index.apt > 2233 11-01-12 22:57 apache-12/src/site-docs/site.xml > 280 11-01-12 22:57 apache-12/DEPENDENCIES > 11358 11-01-12 22:57 apache-12/LICENSE > 182 11-01-12 22:57 apache-12/NOTICE > -------- ------- > 38596 11 files > > * with jar: > > $ jar tf apache-12-source-release.zip > apache-12/ > apache-12/src/ > apache-12/src/site-docs/ > apache-12/src/site-docs/apt/ > apache-12/pom.xml > apache-12/site-pom.xml > apache-12/src/site-docs/apt/index.apt > apache-12/src/site-docs/site.xml > apache-12/DEPENDENCIES > apache-12/LICENSE > apache-12/NOTICE > > moreover, the org.apache.onami:org.apache.onami.parent:1-incubating > zip archive has built with the > org.apache.apache.resources:apache-source-release-assembly-descriptor:1.0.4 > :) > >>> It should only be in the notice if Onami contains third-party software that >>> requires you mention it [1]. Since this is code that was donated to Apache, >>> I don't think that applies, so you should leave it out. >> >> Makes sense to me too. Do you consider it a blocker? > > It is not a blocker and should be tolerable/acceptable, since previous > maintainers have already been mentioned in NOTICE file, see Any23's > NOTICE[1]. --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
