On Tue, Jun 6, 2017 at 7:49 AM, John D. Ament <johndam...@apache.org> wrote:
> On Tue, Jun 6, 2017 at 7:44 AM Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> Some of the data that you mentioned doesn't need to be in the status
>> file as it can be generated from other sources.  For example:
>> https://whimsy.apache.org/board/agenda/json/podlingnamesearch.  I'll
>> refactor that code and add that information to the ppmc pages of the
>> roster tool.
>
> I don't see the code that generates this.  Where did it come from?

Here's the code:

https://github.com/apache/whimsy/blob/6752628340f330303089fd7521724381f653ca97/www/board/agenda/routes.rb#L186

The parsing logic will move to
https://github.com/apache/whimsy/blob/master/lib/whimsy/asf/podlings.rb,
and therefore be usable by multiple tools (in this case, the board
agenda and roster tools).

>> YAML is more human editable than JSON.  As Sebb points out elsewhere,
>> it also supports comments.
>>
>> One thing that whimsy should do is spit out a digested and accumulated
>> set of information in JSON which can be read by other tools.  A good
>> place for a public view would be the phonebook application.
>>
>
> Agreed.  All of the changes I have locally are going into
> public_podlings.json first.  Once that works, we can start to incorporate
> into other pages.

Recommendation: add any logic to
https://github.com/apache/whimsy/blob/master/lib/whimsy/asf/podlings.rb
and similar pages, have the existing cron job that extracts that data
merely fetch it from the library.  The library can then be used by the
roster tool.

- Sam Ruby

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to