Hi Justin, Thank you for your reply.
2018-02-06 16:12 GMT+09:00 Justin Mclean <jus...@classsoftware.com>: > Note the mix of public and private lists (as I’m replying to where it was > sent). CC'd private@ to notify discussion to our project mentors. Changed to dev@ > From a quick look: > - In LICENSE you need to link to the full text of the license locally not via > URL [1] licenses at URLs can change over time. Having the exact version and a > URL is useful but shouldn’t be the primary way to include license information. To clear discussion, the missing license body is specifically for https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315 font-awesome does not include license body just use link to OFL 1.1 for Font license. https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt#L13 We need to fill copyrights of OFL 1.1 [2] but copyright of font-awesome is unclear. OFL 1.1 copyright form is not willed. https://github.com/FortAwesome/Font-Awesome/issues/5281 Font-awesome uses github mention for Copyright (unclear). https://github.com/apache/incubator-hivemall/blob/master/src/site/resources/css/font-awesome.css#L2 BTW, font-awesome is widely used in many ASF projects. https://github.com/search?utf8=%E2%9C%93&q=org%3Aapache+SIL+Open+Font+License+filename%3ALICENSE&type=Code So, I would like to follow the other TLP project passing ASF legal checks for this incubator release. https://github.com/apache/flink/blob/34e106f63c9dcd2673d66b47fda1555b7dced770/LICENSE#L301 https://github.com/apache/tez/blob/247719d7314232f680f028f4e1a19370ffb7b1bb/tez-dist/dist-files/full/LICENSE#L352 https://github.com/apache/calcite/blob/0938c7b6d767e3242874d87a30d9112512d9243a/LICENSE#L264 https://github.com/apache/phoenix/blob/ee4355791acf3f31568fcd8c43367947d25a1386/LICENSE#L233 Isn't it acceptable? > - The NOTICE file still contains too much information [2] Made NOTICE clean and revised License headers following [1] with the following commit: https://github.com/apache/incubator-hivemall/commit/147f26fa25bacb4134256a01f6ff84e14a505b7a I expect it resolves your concern. > Your mentors can help you out with this, please ask them to help. Sure. Makoto [1] https://www.apache.org/legal/src-headers.html#3party [2] http://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=OFL_plaintext&filename=OFL.txt -- Makoto YUI <myui AT apache.org> Research Engineer, Treasure Data, Inc. http://myui.github.io/ --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
