+1. Reviewed diff between 1.1.0 and 1.2.0 source releases for anything unusual. Sampled new files in 1.2.0 for source headers. Happy to see the dmlc code folded into 3rd-party so it's clearer for users/reviewers.
Good patient release-managering btw with all those side-issues on the vote thread regarding flaky tests/CI fails. Hen On Tue, May 8, 2018 at 10:36 AM, Anirudh <anirudh2...@gmail.com> wrote: > Hi all, > > This is a call for releasing Apache MXNet (incubating) 1.2.0, release > candidate RC2. > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7 > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E > > Results thread: > https://lists.apache.org/thread.html/4c55ab75f6781e835d4b3e564904a4 > 3680c760e619d741ce00c55962@%3Cdev.mxnet.apache.org%3E > > The source tarball, including signatures, digests etc. can be found at: > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc2/ > > The release tag can be found here: > https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc2 > > The release hash is 60641ef1183bb4584c9356e84b6ca6d5fce58d6d and can be > found here: > https://github.com/apache/incubator-mxnet/commit/ > 60641ef1183bb4584c9356e84b6ca6d5fce58d6d > > Release artifacts are signed with the following key: > 6E67 8509 715E 3B63 CDB2 234F F8F3 3A11 7CC1 8E95 > > KEYS file available: > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS > > <https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS> > For information on the contents of the release see: > > https://cwiki.apache.org/confluence/display/MXNET/ > Apache+MXNet+%28incubating%29+1.2.0+Release+Notes > > The vote will end at 10:30 AM on Friday, May 11th, PDT. > > [ ] +1 Release this package as 1.2.0 > [ ] +0 no opinion > [ ] -1 Do not release this package because ... > > Anirudh >