Hi Justin, I have a few questions on the category b issues that you raised:
1. example/nce-loss/README.md: This script doesn't ship with CC-BY-SA and GFDL content by itself but downloads the dataset when user runs the script example/nce-loss/get_text8.sh. 2. python/mxnet/gluon/contrib/data/text.py: Here the datasets WikiText2 and WikiText103 with "Creative Commons Attribution-ShareAlike" are also downloaded when calling API: mxnet.gluon.contrib.data.text.WikiText2 and mxnet.gluon.contrib.data.text.WikiText103. It also appears in the mxnet docs here which will help make end users aware about it: https://mxnet.incubator.apache.org/api/python/gluon/contrib.html?highlight=wikitext2#mxnet.gluon.contrib.data.text.WikiText2 3. 3rdparty/googletest/googletest/docs/DevGuide.md: For this issue Meghna raised this question on legal-discuss@ https://mail-archives.apache.org/mod_mbox/www-legal-discuss/201804.mbox/%3CCAMGgKDDEDkSo-dff_GxU19B7JKMpUz3w6bGTYDs3XbJzyKAOGg%40mail.gmail.com%3E The problem is that this license is part of googletest submodule and thus it is not easy for us to remove it without modifying the googletest repo itself. I have mentioned this issue in the known issues of the RELEASE. For 1 and 2, Considering that the Creative Commons License files aren't part of the release source itself but downloaded when user calls some specific api or runs some script, would these be blocking issues ? For 3, I have added it to known issues and I look forward to any other suggestions you have related to this. I would really appreciate any other advice or suggestions you have on how to handle these issues. Anirudh On Fri, May 11, 2018 at 10:56 AM, Anirudh <anirudh2...@gmail.com> wrote: > Hi Justin, > > Just to make sure I understand: Do you want us to review rat-excludes file > to make sure we are not omitting important ? We will check the rat-excludes > file. > Also, the huge number of files(when run without rat-excludes) is because > of the third party submodules for whom the licenses have been added to > LICENSE. > > Anirudh > > On Fri, May 11, 2018 at 1:44 AM, Justin Mclean <jus...@classsoftware.com> > wrote: > >> Hi, >> >> > I am not able to reproduce the issue you mentioned with unknown >> licenses. >> > When I try to run apache rat on the downloaded source it says 0 unknown >> > licenses. Does the source you are looking at include build artifacts by >> > chance ? >> >> No it wasn't but I was ignoring the rat exclusions. Perhaps they have >> been set too wide wouldn’t be the first time that’s happened. >> >> Thanks, >> Justin >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >
