Julian, On 2018/05/10 18:40:12, Julian Hyde <jh...@apache.org> wrote: > I agree about the missing DISCLAIMER file and the missing disclaimer in > README.md. -1 until those are fixed. > > Regarding directories, I disagree. Common practice is to have everything > (including NOTICE, README and DISCLAIMER) in a directory that is named after > the release. If you do otherwise, you make it more difficult for the user to > clean up if they accidentally unzip the file in the wrong place. > > In my opinion Crail should have called that directory > “apache-crail-1.0-incubating”, not “incubator-crail”.
Weird. Again, I've been using mac for a while (hate being back on windows so much), is this a windows thing? I've been reviewing mostly tar.gz files recently and I can't think of any that have a nested directory. But it could be my mac was cleaning things up. Do you have some examples I could look at to see the difference? > > Julian > > > > On May 10, 2018, at 10:26 AM, John D. Ament <johndam...@apache.org> wrote: > > > > Also, it could be that I'm back to windows and no idea what I'm doing (I've > > grown to be a mac user), but there's a root incubator-crail folder that's > > in the zip. We typically expect the LICENSE/NOTICE/DISCLAIMER at the root. > > > > Speaking of, there is no DISCLAIMER file and the README.md does not include > > the incubating disclaimer text. One of those two needs to exist. > > > > I reviewed other stuff (rat output, notice file entries, headers,etc). > > That looks fine. If you can fix the disclaimer and repack to not the extra > > directory I'll vote +1, but I'm -1 without that. Disclaimer is the one > > thing we mandate, and i cannot budge on that. I will verify the sig once > > you send me the keys file location. > > > > John > > > > On 2018/05/10 17:07:53, John D. Ament <johndam...@apache.org> wrote: > >> Hi, > >> > >> Where can I find the key that was used to sign these files? > >> > >> John > >> > >> > >> On 2018/05/07 14:49:29, "Jonas Pfefferle" <peppe...@japf.ch> wrote: > >>> Please vote to approve the source release of Apache Crail 1.0-incubating > >>> (RC2). > >>> > >>> The podling dev vote thread: > >>> https://www.mail-archive.com/dev@crail.apache.org/msg00241.html > >>> > >>> The result: > >>> https://www.mail-archive.com/dev@crail.apache.org/msg00249.html > >>> > >>> Commit hash: 749f44206943fcaef0841ed89411013c2dc11d64 > >>> > >>> https://git1-us-west.apache.org/repos/asf?p=incubator-crail.git;a=commit;h=749f44206943fcaef0841ed89411013c2dc11d64 > >>> > >>> Release files can be found at: > >>> https://dist.apache.org/repos/dist/dev/incubator/crail/1.0-rc2/ > >>> > >>> The vote is open for at least 72 hours and passes if a majority of at > >>> least > >>> 3 +1 PMC votes are cast. > >>> > >>> [ ] +1 Release this package as Apache Crail 1.0-incubating > >>> [ ] -1 Do not release this package because ... > >>> > >>> Thanks, > >>> Jonas > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >>> For additional commands, e-mail: general-h...@incubator.apache.org > >>> > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
