Thanks justin. Opened an issue to polish this eventhough these files won't survive graduation. https://github.com/apache/incubator-zipkin/issues/2602
On Fri, May 17, 2019 at 10:04 AM Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > +1 (binding) but there some improvements that can be made. > > I checked: > - incubating in name > - signatures and hashes good > - LICENSE needs a little more work and is missing LICENSE for [2]. > - NOTICE is incorrect as it missing information from this NOTICE [4] > - no unexpected binary files > - source file have ASF header. In fact a couple too many [1] has an ASF > header and two others and this file as well [2] > - can compile from source > > To ensure you are abiding by 3rd party license terms the full license text > generally needs be included (e.g. MIT, BSD). Usually this is done by pointing > a pointer to a file in the distribution in the LICENSE file (not a URL). Some > projects put all of these licenses into a license directory. You might want > to consider doing that. > > Thanks, > Justin > > 1. ./zipkin-2.13.0/zipkin-ui/libs/dagre-d3/js/dagre-d3.js > 2. > ./zipkin-2.14.0/zipkin-server/src/main/java/zipkin2/server/internal/AbstractUnsafeUnaryGrpcService.java > 3. ./zipkin-ui/libs/chosen/chosen.css > 4. https://github.com/line/armeria/blob/master/NOTICE.txt > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
