> If some code license is unknown it's best to ask the author what is it, or better still ask them to license it under a permissive license that’s compatible with the Apache license. As well as the two items mentioned in NOTICE you may also need to check the licenses of code in these files [1][2]
This has been already fixed in the master, but after this release candidate was created. https://github.com/apache/incubator-datasketches-cpp/commit/0427232b9f6b34c3806223c06c3892028390c3c1 Thank you for your vote. On Sat, Sep 14, 2019 at 12:09 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes file > - DISCLAIMER exists (work in progress version) > - LICENSE is missing information c > - NOTICE include license information which should be in LICENSE (see below) > - no unexpected binaries > - All source files have ASF headers > - Can compile on OSX (Mojave) and all tests pass > > If some code license is unknown it's best to ask the author what is it, or > better still ask them to license it under a permissive license that’s > compatible with the Apache license. As well as the two items mentioned in > NOTICE you may also need to check the licenses of code in these files [1][2] > > Thanks, > Justin > > 1. ./fi/include/reverse_purge_hash_map.hpp > 2. ./fi/include/frequent_items_sketch.hpp > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
