> I would remove ALL content below line 9 ( currently lines 9 to 37), as all of that is LICENSE information and belongs in the LICENSE file not NOTICE
Justin, I am confused. Are you proposing to move all attribution from NOTICE to LICENSE? We were told by our lawyer that all attribution belongs to NOTICE, and LICENSE should have applicable licenses only. I also see that you voted on Ratis saying that NOTICE is OK. I am looking at their NOTICE, and it has attribution almost exactly like in our NOTICE. Could you clarify please? Thank you. On Mon, Sep 16, 2019 at 5:15 PM leerho <lee...@gmail.com> wrote: > Thank you Justin for your clarification! > > Thank you Dave for your vote! > > Lee. > > On Mon, Sep 16, 2019 at 4:56 PM Dave Fisher <w...@apache.org> wrote: > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signatures and hashes file > > - DISCLAIMER exists (WIP version) > > - LICENSE present - note it is being fixed for next version > > - NOTICE present - being fixed for next release. > > - no unexpected binaries > > - All source files have ASF headers with noted exceptions. > > - Can compile on OSX (Mojave) and all tests pass (if one follows the > > directions and uses the cmake variant. > > > > Regards, > > Dave > > > > > On Sep 9, 2019, at 12:05 PM, Alexander Saydakov < > > sayda...@verizonmedia.com> wrote: > > > > > > Dear IPMC and Community, > > > > > > This is a call for vote to release Apache DataSketches-cpp version > > > 1.0.0-incubating > > > > > > This is a C++ version of the DataSketches core library with Python > > bindings. > > > > > > This is the first release of this component. > > > > > > We are not going to release any artifacts besides the source code. > > > > > > Results from the PPMC vote: > > > 3 votes were cast. All of the votes were (+1). One of the votes was > from > > a > > > mentor. > > > > > > http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread > > > > > > The release candidate: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/ > > > > > > Source repository: > > > https://github.com/apache/incubator-datasketches-cpp > > > > > > Git tag for this release: > > > > > > https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2 > > > > > > The artifact has been signed with key: > > > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > > > al...@apache.org> > > > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0 > > > > > > The public signing key can be found in the KEYS file: > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > > > Changes from the RC1: > > > - added license to make files > > > - building and running unit tests does not require pybind11 (dependency > > for > > > Python bindings) > > > - better build instructions > > > > > > This library was intended to be header-only, but this goal was not > fully > > > achieved yet with CPC sketch code. This work is in progress. > > > > > > Building and running unit tests requires CppUnit. > > > > > > Installing CppUnit on OSX: brew install cppunit > > > Installing CppUnit on RHEL: yum install cppunit-devel > > > > > > There are currently two ways of building: using existing make files and > > > generating make files using cmake. Exsisting make files might not work > on > > > all platforms or with all C++ compilers. Generating make files using > > cmake > > > should solve this problem, but it currently requires cmake version > 3.12.0 > > > or higher that might not be readily available as a package on all > > platforms. > > > > > > Installing the latest cmake on OSX: brew install cmake > > > > > > Building and running unit tests using existing make files: > > > $ make > > > $ make test > > > > > > Building and running unit tests using cmake: > > > $ mkdir build > > > $ cd build > > > $ cmake .. > > > $ make > > > $ make test > > > > > > Building Python bindings requires cmake 3.12 or higher and pybind11. > > > Please see the following document for details: > > > > > > https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md > > > > > > This is the second stage vote. The vote will remain open for at least > 72 > > > hours and at least 3 (+1) IPMC votes or a majority of (+1) are > acquired. > > > > > > Please vote accordingly: > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > Alexander Saydakov > > > al...@apache.org > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@datasketches.apache.org > > For additional commands, e-mail: dev-h...@datasketches.apache.org > > > > >
