We see integration tests as an even more important and integral part of the source code compared to unit tests since they offer so much more value in ensuring that functionality and compatibility remain the same when we push our software forward. It gives us the freedom to continue progressing in a safe way. That is why I think that splitting these tests off into another repository is a bad idea and the same goes for documentation and the samples really. We really want and need to keep everything in sync with code changes. We hope to have hundreds of extra .hpl/.hwf files for testing and samples in the future. Our mentors in the past thought it was not required to add license headers for these "user-files" hence their exclusion from the RAT checks.
On Fri, Jun 11, 2021 at 10:51 AM Hans Van Akelyen < hans.van.akel...@gmail.com> wrote: > Hi Justin, > > That file should be switched to the standard ASF header and is part of the > original code and covered by the notice file. > > As for the no header in hpl and hwf files, these are files created using > the application and are used for samples and for our integration testing > framework. This framework is an extension on our unit tests mainly used to > see if all functionality is working and that we have no regressions. > As they are created using the application no header is included, they are > not manually created files. > > Cheers, > Hans > > On Fri, 11 Jun 2021 at 09:36, Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > -1 (binding) > > > > This 3rd party file [1] is not mentioned in LICENSE. While this is just > > one file my concern is that that this may indicate a bigger issue where > > headers of 3rd party files have been changed. > > > > I checked: > > - incubating in name > > - signatures and hash are fine > > - LICENSE is missing a mention from a 3rd party file > > - No unexpected binary files > > - There is quite a number of files without ASF headers I assume it could > > be added to some of these (e.g. .hpl or .hwf files) > > - Didn't compile from source > > > > Kind Regards, > > Justin > > > > 1. ./core/src/test/java/org/apache/hop/core/sql/SqlFieldsUnitTest.java > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > -- Neo4j Chief Solutions Architect *✉ *matt.cast...@neo4j.com ☎ +32486972937
