+1 (non-binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE is fine - DISCLAIMER exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - Checksums and PGP signatures are valid. - No compiled archives bundled in source archive.
Best regards Xun Liu On Thu, Jul 29, 2021 at 11:07 AM Zhang Yonglun <zhangyong...@apache.org> wrote: > Hi Sheng, > > Thanks for pointing out this problem. > The escape character in the test class is not compatible with OpenJDK 11. > We plan to support JAVA 11 in the next release. > Please try to build with JAVA 8, and I'll update the release doc to specify > the JAVA version. > > > -- > > Zhang Yonglun > Apache ShenYu (Incubating) > Apache ShardingSphere > > > Sheng Wu <wu.sheng.841...@gmail.com> 于2021年7月29日周四 上午8:50写道： > > > Hi > > > > I can't find the compiling doc in the mail, but when I run compiling > using > > OpenJDK11, it fails > > ``` > > > > Expected: a string containing "Extension instance(name: > canNotInstantiated, > > class: class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could > > not be instantiated: Class org.apache.shenyu.spi.ExtensionLoader can not > > access a member of class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with modifiers > > \"private\"" > > > > but: was "Extension instance(name: canNotInstantiated, class: class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could not be > > instantiated: class org.apache.shenyu.spi.ExtensionLoader cannot access a > > member of class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with > > modifiers "private"" > > > > at > > > > > org.apache.shenyu.spi.ExtensionLoaderTest.testGetExtensionLoaderCanNotInstantiatedSPI(ExtensionLoaderTest.java:186) > > > > > > [INFO] Running org.apache.shenyu.spi.SpiExtensionFactoryTest > > > > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > > 0.003 s - in org.apache.shenyu.spi.SpiExtensionFactoryTest > > > > [INFO] > > > > [INFO] Results: > > > > [INFO] > > > > [ERROR] Failures: > > > > [ERROR] > > ExtensionLoaderTest.testGetExtensionLoaderCanNotInstantiatedSPI:186 > > > > Expected: a string containing "Extension instance(name: > canNotInstantiated, > > class: class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could > > not be instantiated: Class org.apache.shenyu.spi.ExtensionLoader can not > > access a member of class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with modifiers > > \"private\"" > > > > but: was "Extension instance(name: canNotInstantiated, class: class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could not be > > instantiated: class org.apache.shenyu.spi.ExtensionLoader cannot access a > > member of class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with > > modifiers "private"" > > > > [INFO] > > > > [ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 0 > > > > [INFO] > > ``` > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > Willem Jiang <willem.ji...@gmail.com> 于2021年7月29日周四 上午8:02写道： > > > > > +1 (binding) > > > Just forward my vote in the PPMC here. > > > There is incubating in the release kits' name. > > > The maven stage repo looks good. > > > No compiled archives bundled in source archive > > > The LICENSE and NOTICE files are OK for me. > > > There is a DISCLAIMER file in the release kits. > > > I can build the kit from source release with "mvn clean install" > > > > > > > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Tue, Jul 27, 2021 at 10:57 AM Zhang Yonglun < > zhangyong...@apache.org> > > > wrote: > > > > > > > > Hello Incubator Community, > > > > > > > > This is a call for vote to release Apache ShenYu (incubating) version > > > 2.4.0. > > > > > > > > The Apache ShenYu community has voted on and approved a proposal to > > > release > > > > Apache ShenYu (incubating) version 2.4.0. > > > > > > > > We now kindly request the Incubator PMC members review and vote on > this > > > > incubator release. > > > > > > > > ShenYu community vote thread: > > > > > > > > > > https://lists.apache.org/thread.html/r8164d5840fda82b2d8bce5a7075ea874d247f2c0abf9203821a13cbb%40%3Cdev.shenyu.apache.org%3E > > > > > > > > Vote result thread: > > > > > > > > > > https://lists.apache.org/thread.html/re7b26cf370707cdb54a5404e317167fde643d3669e9783e335bf3b5e%40%3Cdev.shenyu.apache.org%3E > > > > > > > > Release notes: > > > > > > https://github.com/apache/incubator-shenyu/blob/master/RELEASE-NOTES.md > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/2.4.0/ > > > > > > > > Maven 2 staging repository: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheshenyu-1012/org/apache/shenyu/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/incubator-shenyu/tree/v2.4.0/ > > > > > > > > Release Commit ID: > > > > > > > > > > https://github.com/apache/incubator-shenyu/commit/c75a273a8a9118411ed367e743b574e7fe0a5a87 > > > > > > > > Keys to verify the Release Candidate: > > > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/KEYS > > > > > > > > Look at here for how to verify this release candidate: > > > > https://shenyu.apache.org/community/release/#check-release > > > > > > > > GPG user ID: > > > > zhangyonglun > > > > > > > > The vote will be open for at least 72 hours or until necessary number > > of > > > > votes are reached. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > Checklist for reference: > > > > > > > > [ ] Download links are valid. > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > [ ] Source code distributions have correct names matching the current > > > > release. > > > > > > > > [ ] LICENSE and NOTICE files are correct for each ShenYu repo. > > > > > > > > [ ] All files have license headers if necessary. > > > > > > > > [ ] No compiled archives bundled in source archive. > > > > > > > > -- > > > > > > > > Zhang Yonglun > > > > Apache ShenYu (Incubating) > > > > Apache ShardingSphere > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > >
